Search box shouldn't always use the first suggestion #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you select an item from the search box dropdown, we were processing the event twice: once in typeahead:select and once on keydown. The second handler was overwriting the window.location generated by the first and always sending the user to the first suggestion even if they had selected a different suggestion. Fixes dart-lang#1330
|
/cc @keertip @devoncarew |
|
Not sure why Travis is mad. Seems unrelated to this patch... |
|
Some of the sdk dartdocs get inlined into the generated docs for our sample project; our build compares the committed samples docs w/ the latest output. I'll re-gen to fix. Thanks for the patch! Merging... |
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you select an item from the search box dropdown, we were processing
the event twice: once in typeahead:select and once on keydown. The
second handler was overwriting the window.location generated by the
first and always sending the user to the first suggestion even if they
had selected a different suggestion.
Fixes #1330