Remove appveyor hack #1508
Closed
Remove appveyor hack #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the story w/ this, @jcollins-g ? |
|
This can not be submitted until the referenced pub bug is fixed. |
kevmoo
added
the
status-blocked
|
Moved this issue to the pub repo - dart-lang/pub#1751 |
|
Is this still relevant, or can we close this? |
jcollins-g
removed
the
status-blocked
|
There seems to be something else going on that requires the original hack to remain in place. Closing for now, but will investigate if it turns out to be a symptom of a real problem (like the original spath bug). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pub global activate -spath . seems to have bugs relating to relative paths in pubspec.yaml. Only needed for testing purposes in this package.
The appveyor hack fixes appveyor, and something like it has to be done locally too to complete grind test. We can avoid the hack through this PR, but then we break the flutter bot with the spath bug. Creating this PR to reference in an upcoming SDK bug, and to have a branch pub developers can check out to reproduce the problem.