Update analyzer, fix checked mode runs for flutter, and unpin bots. #1606
Conversation
jcollins-g
changed the title
jcollins-g
changed the title
| @@ -1,7 +1,7 @@ | |||
| language: dart | |||
| sudo: false | |||
| dart: | |||
| - "dev/release/2.0.0-dev.22.0" | |||
| - "dev/raw/latest" | |||
There was a problem hiding this comment.
I'm actually looking for raw here. Not all versions that we actually wind up using in internal rolls, etc, get published to release right away, and I'd like to have the bots go red on a problem ahead of that.
appveyor.yml
Outdated
| @@ -3,7 +3,7 @@ | |||
| # BSD-style license that can be found in the LICENSE file. | |||
|
|
|||
| install: | |||
| - ps: wget https://gsdview.appspot.com/dart-archive/channels/dev/raw/2.0.0-dev.22.0/sdk/dartsdk-windows-x64-release.zip -OutFile dart-sdk.zip | |||
| - ps: wget https://gsdview.appspot.com/dart-archive/channels/dev/raw/latest/sdk/dartsdk-windows-x64-release.zip -OutFile dart-sdk.zip | |||
There was a problem hiding this comment.
Should be https://storage.googleapis.com/dart-archive/channels/dev/release/latest/sdk/dartsdk-windows-x64-release.zip
There was a problem hiding this comment.
This is the "official" external URI
There was a problem hiding this comment.
At least change the domain. gsdview.appspot.com is a weird internal tool that happens to work.
No promises that it will stick around. It adds a layer on to downloading the SDK, etc.
There was a problem hiding this comment.
Oh, yeah, good idea. No idea why it was this way in the first place. Done.
| @@ -427,7 +427,7 @@ Future<List<Map>> _buildFlutterDocs( | |||
| workingDirectory: await futureCwd); | |||
| return await launcher.runStreamed( | |||
| flutterCacheDart, | |||
| [path.join('dev', 'tools', 'dartdoc.dart'), '--json'], | |||
| [path.join('dev', 'tools', 'dartdoc.dart'), '-c', '--json'], | |||
Fixes #1602.
Checked mode failures were due to a bug in the markdown processor. Add a test for that change, update analyzer (required for checked mode to work), and unpin travis/appveyor so we again use the latest SDK builds.