Skip to content

Generate anchors for headers in markdown #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2018
Merged

Generate anchors for headers in markdown #1749

merged 5 commits into from
Aug 28, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Aug 27, 2018 •
edited
Loading

Fixes #1710.

Dartdoc was using the wrong github markdown flavor. A new one allows automatically generating the ids, which is exactly what we need.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Aug 27, 2018
@jcollins-g jcollins-g mentioned this pull request Aug 27, 2018
Closed
devoncarew
devoncarew approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some CI bot failures; lgtm once they're happy.

@jcollins-g jcollins-g merged commit 3b4cd0c into master Aug 28, 2018
@jcollins-g jcollins-g deleted the anchors branch November 27, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @devoncarew @googlebot