Skip to content

Convert the missing constructor assert into an ignored warning #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

Convert the missing constructor assert into an ignored warning #2178

merged 1 commit into from
Apr 13, 2020

Conversation

jcollins-g
Copy link
Contributor

Reconsidered #2176. It's still useful while debugging package structure but not really assert material; we know how to recover from this.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 10, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 91.77% when pulling 392f581 on warning-for-missing-constructor into 1cd44e6 on master.

@jcollins-g jcollins-g merged commit 086815c into master Apr 13, 2020
@jcollins-g jcollins-g deleted the warning-for-missing-constructor branch April 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@stereotype441 stereotype441 Awaiting requested review from stereotype441

@MichaelRFairhurst MichaelRFairhurst Awaiting requested review from MichaelRFairhurst

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @srawlins @googlebot