Remove dependency on deprecated resource package. #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy implementation for loading bytes from a 'package:' URI.
devoncarew
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
👍
One other thing we could do, if we want to remove the need to load resources from the filesystem, is to encode the template and css files into dart source code. I don't think having to load resources from the filesystem is an issue, but thought I would mention the option.
|
Yeah I can see us doing that longterm. There are a lot of templates so it would perhaps be quite a task to set this up with the build package... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy implementation for loading bytes from a 'package:' URI.