Skip to content

Introduce Mustachio mustache parser #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2020
Merged

Introduce Mustachio mustache parser #2417

merged 2 commits into from
Nov 5, 2020

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Nov 4, 2020

Mustachio is a new codegen-based Mustache renderer. This first PR is just the parser. No variable resolution is performed.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Nov 4, 2020
@srawlins srawlins requested a review from jcollins-g November 5, 2020 15:36
jcollins-g
jcollins-g approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't written a real parser in a very long time, but this seems reasonable.

@jcollins-g
Copy link
Contributor

Looks like bots are complaining about a dependency not being in the right place.

@srawlins srawlins merged commit 85ae869 into dart-lang:master Nov 5, 2020
@srawlins srawlins deleted the mustachio branch November 5, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @jcollins-g