Skip to content

Introduce a Mustachio Builder. #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Nov 9, 2020

This change is mostly concerned with gathering 'Renderer' annotations (which
isn't included yet; only a mock is included in specs), and walking the graph of
properties and types to gather all of the types which need renderers, for
resolving keys into property values.

There isn't much generated code in this change, but the base renderer is
included, which is referenced in generated renderer classes (stubs, for now).

This change is mostly concerned with gathering 'Renderer' annotations (which
isn't included yet; only a mock is included in specs), and walking the graph of
properties and types to gather all of the types which need renderers, for
resolving keys into property values.

There isn't much generated code in this change, but the base renderer is
included, which is referenced in generated renderer classes (stubs, for now).
@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Nov 9, 2020
@srawlins srawlins requested a review from jcollins-g November 9, 2020 19:36
@srawlins srawlins merged commit 847121d into dart-lang:master Nov 16, 2020
@srawlins srawlins deleted the mustachio-2 branch November 16, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants