Skip to content

Fix members not being marked as inherited in sidebars - Fixes #2472 #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2021

Conversation

parlough
Copy link
Member

@parlough parlough commented Dec 28, 2020

Inherited issue:
This switches to sharing the sections with inherited features between class and enum.

Fixes #2472

Operator issue:

Handling of checking if all instance operators are inherited was messed up, resulting in the operators section always being marked as inherited(multiple times in fact) and being italicized. This standardizes it to match the behavior of methods.

The second commit addresses this issue.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Dec 28, 2020
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please add at least a test for the publicInheritedInstanceOperators method. I think an end-to-end verification is probably redundant but optionally you could add that as well to double-check rendering.

@parlough
Copy link
Member Author

parlough commented Jan 5, 2021

Great work! Please add at least a test for the publicInheritedInstanceOperators method. I think an end-to-end verification is probably redundant but optionally you could add that as well to double-check rendering.

Thanks for the feedback! I'll address the desired changes and add the tests sometime later today.

@parlough
Copy link
Member Author

parlough commented Jan 5, 2021

@jcollins-g I believe I have addressed your raised issues as well as added some small tests. Let me know if you'd like to see any other changes. Thanks 🥇

Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, will land once green.

@jcollins-g jcollins-g merged commit 7c68375 into dart-lang:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherited methods are no longer italics in the right sidebar (regression)
2 participants