-
Notifications
You must be signed in to change notification settings - Fork 127
Fix members not being marked as inherited in sidebars - Fixes #2472 #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix members not being marked as inherited in sidebars - Fixes #2472 #2473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Please add at least a test for the publicInheritedInstanceOperators method. I think an end-to-end verification is probably redundant but optionally you could add that as well to double-check rendering.
Thanks for the feedback! I'll address the desired changes and add the tests sometime later today. |
@jcollins-g I believe I have addressed your raised issues as well as added some small tests. Let me know if you'd like to see any other changes. Thanks 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, will land once green.
Inherited issue:
This switches to sharing the sections with inherited features between
class
andenum
.Fixes #2472
Operator issue:
Handling of checking if all instance operators are inherited was messed up, resulting in the operators section always being marked as inherited(multiple times in fact) and being italicized. This standardizes it to match the behavior of methods.
The second commit addresses this issue.