Skip to content

Fix three little issues in mustachio codegen #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

srawlins
Copy link
Member

  • Allow duplicate types in different @Renderer specifications.
  • Only build each render class and renderer method once; you cannot declare two
    classes or functions with the same name.
  • Do not attempt to add generators for type parameters; instead, use the bound
    if it is not dynamic.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jan 26, 2021
* Allow duplicate types in different `@Renderer` specifications.
* Only build each render class and renderer method once; you cannot declare two
  classes or functions with the same name.
* Do not attempt to add generators for type parameters; instead, use the bound
  if it is not `dynamic`.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.605% when pulling 9704ed4 on srawlins:mustachio-f into 0ba8dc8 on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g January 27, 2021 23:17
@srawlins srawlins merged commit 8cf5e87 into dart-lang:master Jan 28, 2021
@srawlins srawlins deleted the mustachio-f branch January 28, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants