Mustachio: generate renderer code for mixed in types #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Feb 4, 2021
| if (contextClass.mixins != null) { | ||
| // Mixins are spread into the property map _after_ the super class, so | ||
| // that they override any values which need to be overridden. Superclass | ||
| // and mixins override from left to right, as do spreads: |
There was a problem hiding this comment.
is this not right to left? (N overrides M, which overrides E). Or am I thinking about this wrongly.
There was a problem hiding this comment.
Hmm yeah maybe the semantics are meaningless. I mean that mixins are applied left to right. So M is applied, then N is applied, overriding things from M.
There was a problem hiding this comment.
ah yes. They are applied left to right, which implies that they override right to left. Implied applies applies implying....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, regenerate renderers with
Packagevisible. The Package class mixes in 4 classes which highlights the solution in this change; each of the 4 mixins gets its own renderer class.Bringing in these major mixins brings the generated code to 2000 LOCs.