Mustachio: cache property map for each type #2549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the property maps are each a static function, rather than a getter, because they need to be type parameterized. In this case, however, they are built up every time a property needs to be accessed during mustache rendering. Here's one example, the property map for Package:
Package extends LibraryContainer, so it's property map is spread in first. Package then mixes in Nameable, Locatable, Canonicalization, and Warnable, so those are each spread in next. Finally, Package declares its own methods, like allLibraries, which are added last. Each property like allLibraries contains a few function literals. Overall, this Map is expensive to compute repeatedly.
By caching it on the context type,
CT_
, we generally build it very few times per renderer type. Generics don't play a huge role, so each renderer ultimately supports a small handful of types, typically one.