Temporarily ignore fenced code block warning by default for release #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parlough Are you sure this is necessary? Warnings are more advisory here than they are in the analyzer and people do have the option to explicitly ignore this for their project if need be. |
|
Well, after poking around a bit, I will go ahead and land this as you requested, there are still warnings in Flutter for this problem. |
jcollins-g
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the next release, I gave it some more thought and I think we should ignore this warning by default for now. Gives users an indication to start identifying code blocks and they can enable it if desired. Perhaps we can specify in the changelog that this warning is added and users should start specifying language identifiers. In a later release, we can investigate enabling it by default again.
I planned to do some downstream cleanup for popular packages, libraries, and frameworks but didn't have as much time as I would have liked yet. I should have time to finalize that work soon.
@jcollins-g