Skip to content

Integrate new parser with new lookup code #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

Integrate new parser with new lookup code #2637

merged 2 commits into from
May 7, 2021

Conversation

jcollins-g
Copy link
Contributor

This increases the new lookup code compliance to ~91% on the SDK.

Documented 18 public libraries in 30.7 seconds
Reference Counts:
total references: 29543
resolved references:  22306 (75.50350336797212%)
resolved references with new lookup:  26590 (90.00440036556884%)
resolved references with old lookup:  22306 (75.50350336797212%)
resolved references with equivalent links:  26844 (90.86416409978675%)

Getting close enough now that more direct integration tests involving lookups seem like a good idea -- model_test.dart's comment reference tests are going to need an overhaul to make that possible and will do that in a followup.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label May 6, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 57.691% when pulling c210add on jcollins-g:parser-integrate into 62e25f1 on dart-lang:master.

@jcollins-g jcollins-g requested a review from srawlins May 6, 2021 23:22
srawlins
srawlins approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/src/comment_references/model_comment_reference.dart
/// Does the structure of the reference itself imply a possible default
/// constructor?
// TODO(jcollins-g): rewrite/discard this once default constructor tear-off
// design process is complete.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss +1

@jcollins-g jcollins-g merged commit bd11290 into dart-lang:master May 7, 2021
@jcollins-g jcollins-g deleted the parser-integrate branch May 7, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @coveralls @srawlins