Skip to content

Upgrade dartdoc #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

Upgrade dartdoc #4218

merged 1 commit into from
Nov 6, 2020

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Nov 5, 2020

@isoos isoos requested a review from jonasfj November 5, 2020 07:27
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@CaptainIRS CaptainIRS mentioned this pull request Nov 5, 2020
Closed
@jonataslaw
Copy link

Nice PR!

@isoos isoos merged commit fb655a9 into dart-lang:master Nov 6, 2020
@isoos isoos deleted the upgrade-dartdoc branch November 6, 2020 12:41
@jonataslaw
Copy link

jonataslaw commented Nov 10, 2020 •
edited
Loading

Hi, sorry if this question is noob, but after the merge the deployment was made for pub.dev?
Because I just sent an update now to the pub, and the problem still persists:
97118203-7d471900-16e7-11eb-95b9-bb03c4cb16d9

url: https://pub.dev/packages/get

Is there any alternative way to resolve this? The package score on pub.dev was downgraded, and because of that, the package that is one of the top 10 in Flutter is in the +100 position of relevance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pub.dev fails to run dartdoc: "NoSuchMethodError: The getter 'documentationComment' was called on null."
3 participants
@isoos @jonataslaw @jonasfj