Give error if global activated package depends on hooks

lib/src/command/deps.dart

@@ -417,7 +417,12 @@ class DepsCommand extends PubCommand {
       ],
     ];
     return nonDevDependencies
-        .expand(graph.transitiveDependencies)
+        .expand(
+          (p) => graph.transitiveDependencies(
+            p,
+            followDevDependenciesFromRoot: false,
+          ),
+        )
         .map((package) => package.name)
         .toSet();
   }

lib/src/command/upgrade.dart

@@ -121,8 +121,12 @@ class UpgradeCommand extends PubCommand {
       final graph = await entrypoint.packageGraph;
       return argResults.rest
           .expand(
-            (package) =>
-                graph.transitiveDependencies(package).map((p) => p.name),
+            (package) => graph
+                .transitiveDependencies(
+                  package,
+                  followDevDependenciesFromRoot: true,
+                )
+                .map((p) => p.name),
           )
           .toSet()
           .toList();

lib/src/global_packages.dart

@@ -174,6 +174,23 @@ class GlobalPackages {
     );
   }
 
+  void _testForHooks(Package package, String activatedPackageName) {
+    final prelude =
+        (package.name == activatedPackageName)
+            ? 'Package $activatedPackageName uses hooks.'
+            : 'The dependency of $activatedPackageName, '
+                '${package.name} uses hooks.';
+    if (fileExists(p.join(package.dir, 'hooks', 'build.dart'))) {
+      fail('''
+$prelude
+
+You currently cannot `global activate` packages relying on hooks.
+
+Follow progress in https://github.com/dart-lang/sdk/issues/60889.
+''');
+    }
+  }
+
   /// Makes the local package at [path] globally active.
   ///
   /// [executables] is the names of the executables that should have binstubs.
@@ -194,6 +211,10 @@ class GlobalPackages {
     await entrypoint.acquireDependencies(SolveType.get);
     final activatedPackage = entrypoint.workPackage;
     final name = activatedPackage.name;
+    for (final package in (await entrypoint.packageGraph)
+        .transitiveDependencies(name, followDevDependenciesFromRoot: false)) {
+      _testForHooks(package, name);
+    }
     _describeActive(name, cache);
 
     // Write a lockfile that points to the local package.
@@ -260,10 +281,27 @@ class GlobalPackages {
       }
       rethrow;
     }
+
     // We want the entrypoint to be rooted at 'dep' not the dummy-package.
     result.packages.removeWhere((id) => id.name == 'pub global activate');
 
     final lockFile = await result.downloadCachedPackages(cache);
+
+    // Because we know that the dummy package never is a workspace we can
+    // iterate all packages.
+    for (final package in result.packages) {
+      _testForHooks(
+        // TODO(sigurdm): refactor PackageGraph to make it possible to query
+        // without loading the entrypoint.
+        Package(
+          result.pubspecs[package.name]!,
+          cache.getDirectory(package),
+          [],
+        ),
+        name,
+      );
+    }
+
     final sameVersions =
         originalLockFile != null && originalLockFile.samePackageIds(lockFile);
 

lib/src/package_graph.dart

@@ -2,14 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:graphs/graphs.dart';
-
 import 'entrypoint.dart';
 import 'package.dart';
 import 'solver.dart';
 import 'source/cached.dart';
 import 'source/sdk.dart';
-import 'utils.dart';
 
 /// A holistic view of the entire transitive dependency graph for an entrypoint.
 class PackageGraph {
@@ -23,9 +20,6 @@ class PackageGraph {
   /// relevant in the current context.
   final Map<String, Package> packages;
 
-  /// A map of transitive dependencies for each package.
-  Map<String, Set<Package>>? _transitiveDependencies;
-
   PackageGraph(this.entrypoint, this.packages);
 
   /// Creates a package graph using the data from [result].
@@ -55,28 +49,25 @@ class PackageGraph {
   /// For the entrypoint this returns all packages in [packages], which includes
   /// dev and override. For any other package, it ignores dev and override
   /// dependencies.
-  Set<Package> transitiveDependencies(String package) {
-    if (package == entrypoint.workspaceRoot.name) {
-      return packages.values.toSet();
-    }
+  Set<Package> transitiveDependencies(
+    String package, {
+    required bool followDevDependenciesFromRoot,
+  }) {
+    final result = <Package>{};
 
-    if (_transitiveDependencies == null) {
-      final graph = mapMap<String, Package, String, Iterable<String>>(
-        packages,
-        value: (_, package) => package.dependencies.keys,
-      );
-      final closure = transitiveClosure(graph.keys, (n) => graph[n]!);
-      _transitiveDependencies =
-          mapMap<String, Set<String>, String, Set<Package>>(
-            closure,
-            value: (depender, names) {
-              final set = names.map((name) => packages[name]!).toSet();
-              set.add(packages[depender]!);
-              return set;
-            },
-          );
+    final stack = [package];
+    final visited = <String>{};
+    while (stack.isNotEmpty) {
+      final current = stack.removeLast();
+      if (!visited.add(current)) continue;
+      final currentPackage = packages[current]!;
+      result.add(currentPackage);
+      stack.addAll(currentPackage.dependencies.keys);
+      if (followDevDependenciesFromRoot && current == package) {
+        stack.addAll(currentPackage.devDependencies.keys);
+      }
     }
-    return _transitiveDependencies![package]!;
+    return result;
   }
 
   bool _isPackageFromImmutableSource(String package) {
@@ -98,6 +89,7 @@ class PackageGraph {
 
     return transitiveDependencies(
       package,
+      followDevDependenciesFromRoot: true,
     ).any((dep) => !_isPackageFromImmutableSource(dep.name));
   }
 }

pubspec.lock

@@ -5,18 +5,18 @@ packages:
     dependency: transitive
     description:
       name: _fe_analyzer_shared
-      sha256: e55636ed79578b9abca5fecf9437947798f5ef7456308b5cb85720b793eac92f
+      sha256: c81659312e021e3b780a502206130ea106487b34793bce61e26dc0f9b84807af
       url: "https://pub.dev"
     source: hosted
-    version: "82.0.0"
+    version: "83.0.0"
   analyzer:
     dependency: "direct main"
     description:
       name: analyzer
-      sha256: "904ae5bb474d32c38fb9482e2d925d5454cda04ddd0e55d2e6826bc72f6ba8c0"
+      sha256: "9c35a79bf2a150b3ea0d40010fbbb45b5ebea143d47096e0f82fd922a324b49b"
       url: "https://pub.dev"
     source: hosted
-    version: "7.4.5"
+    version: "7.4.6"
   args:
     dependency: "direct main"
     description:
@@ -257,6 +257,14 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "2.2.0"
+  retry:
+    dependency: "direct main"
+    description:
+      name: retry
+      sha256: "822e118d5b3aafed083109c72d5f484c6dc66707885e07c0fbcb8b986bba7efc"
+      url: "https://pub.dev"
+    source: hosted
+    version: "3.1.2"
   shelf:
     dependency: "direct main"
     description:
@@ -474,4 +482,4 @@ packages:
     source: hosted
     version: "2.2.2"
 sdks:
-  dart: ">=3.7.0 <4.0.0"
+  dart: ">=3.8.0 <4.0.0"

pubspec.yaml

@@ -20,6 +20,7 @@ dependencies:
   path: ^1.9.1
   pool: ^1.5.1
   pub_semver: ^2.2.0
+  retry: ^3.1.2
   shelf: ^1.4.2
   source_span: ^1.10.1
   stack_trace: ^1.12.1

test/global/activate/activate_package_with_hooks_test.dart

@@ -0,0 +1,138 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:path/path.dart' as p;
+import 'package:test/test.dart';
+
+import '../../descriptor.dart';
+import '../../test_pub.dart';
+
+void main() {
+  test(
+    'activating a package from path gives error if package uses hooks',
+    () async {
+      final server = await servePackages();
+      server.serve(
+        'uses_hooks',
+        '1.0.0',
+        contents: [
+          dir('hooks', [file('build.dart')]),
+        ],
+      );
+      server.serve('uses_no_hooks', '1.0.0');
+
+      await dir(appPath, [
+        libPubspec(
+          'foo',
+          '1.2.3',
+          extras: {
+            'workspace': [
+              'pkgs/foo_hooks',
+              'pkgs/foo_dev_hooks',
+              'pkgs/foo_no_hooks',
+            ],
+          },
+          sdk: '^3.5.0',
+        ),
+        dir('pkgs', [
+          dir('foo_hooks', [
+            libPubspec(
+              'foo_hooks',
+              '1.1.1',
+              deps: {'uses_hooks': '^1.0.0'},
+              resolutionWorkspace: true,
+            ),
+          ]),
+          dir('foo_dev_hooks', [
+            libPubspec(
+              'foo_dev_hooks',
+              '1.1.1',
+              devDeps: {'uses_hooks': '^1.0.0'},
+              resolutionWorkspace: true,
+            ),
+          ]),
+          dir('foo_no_hooks', [
+            libPubspec(
+              'foo_no_hooks',
+              '1.1.1',
+              deps: {'uses_no_hooks': '^1.0.0'},
+              resolutionWorkspace: true,
+            ),
+          ]),
+        ]),
+      ]).create();
+
+      await runPub(
+        args: ['global', 'activate', '-spath', p.join('pkgs', 'foo_hooks')],
+        environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+        error: '''
+The dependency of foo_hooks, uses_hooks uses hooks.
+
+You currently cannot `global activate` packages relying on hooks.
+
+Follow progress in https://github.com/dart-lang/sdk/issues/60889.''',
+        exitCode: 1,
+      );
+
+      await runPub(
+        args: ['global', 'activate', '-spath', p.join('pkgs', 'foo_dev_hooks')],
+        environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      );
+
+      await runPub(
+        args: ['global', 'activate', '-spath', p.join('pkgs', 'foo_no_hooks')],
+        environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      );
+    },
+  );
+
+  test('activating a hosted package gives error if package uses hooks in direct'
+      ' dependency', () async {
+    final server = await servePackages();
+    server.serve(
+      'uses_hooks',
+      '1.0.0',
+      contents: [
+        dir('hooks', [file('build.dart')]),
+      ],
+    );
+    server.serve('foo_hooks', '1.1.1', deps: {'uses_hooks': '^1.0.0'});
+    server.serve(
+      'foo_hooks_in_dev_deps',
+      '1.0.0',
+      pubspec: {
+        'dev_dependencies': {'uses_hooks': '^1.0.0'},
+      },
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'uses_hooks'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      error: '''
+Package uses_hooks uses hooks.
+
+You currently cannot `global activate` packages relying on hooks.
+
+Follow progress in https://github.com/dart-lang/sdk/issues/60889.''',
+      exitCode: 1,
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'foo_hooks'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      error: '''
+The dependency of foo_hooks, uses_hooks uses hooks.
+
+You currently cannot `global activate` packages relying on hooks.
+
+Follow progress in https://github.com/dart-lang/sdk/issues/60889.''',
+      exitCode: 1,
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'foo_hooks_in_dev_deps'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+    );
+  });
+}