pkg/dartdev/test/commands/doc_test flaky -> Timeout

[alexmarkov]

There are new test failures on Convert more methods from KeywordContributor...[dart2wasm] Extend _makeFunctionType for functions with multiple return values.

The tests

pkg/dartdev/test/commands/doc_test Timeout (expected Pass)

are failing on configurations

unittest-asserts-debug-linux

Log: https://dart-ci.appspot.com/log/pkg-linux-debug/unittest-asserts-debug-linux/18024/pkg/dartdev/test/commands/doc_test

[srawlins]

CC @bwilkerson

[bwilkerson]

The test that is timing out is testing the command-line dart doc tool. It isn't clear to me how either of those CLs (especially the first, which only changes code in the analysis server that can't be being run) would impact the performance of that test.

[alexmarkov]

The test was flaky, and then started failing consistently. So this timeout is not necessarily caused by the mentioned CLs.

[srawlins]

Is there a page showing the status of this test for every commit? I just ran it locally at HEAD (425182c) and it finished in 2 minutes, which I think is standard. In the failure linked above, it took at least 14 minutes.

[alexmarkov]

Note that it is timing out in debug mode (unittest-asserts-debug-linux), which is probably slower than release.

[srawlins]

OK the Golem bots show that we've returned to normal, and a local Debug64 test of doc_test.dart showed a normal completion time. Is this good to close?

[alexmarkov]

The test is still failing with timeout on unittest-asserts-debug-linux configuration: https://dart-current-results.web.app/#/filter=pkg/dartdev/test/commands/doc_test&showAll.

Log: https://dart-ci.appspot.com/log/any/unittest-asserts-debug-linux/18057/pkg/dartdev/test/commands/doc_test.

If this is an expected behavior, we can increase its timeout or skip this test in debug mode.

[srawlins]

No I think 14 minutes is unexpectedly long...

[parlough]

I didn't look closely into either issue and I may be completely off, but I wonder if the core issue here is potentially similar to #53229 which was also running quite slow in debug mode.

[srawlins]

I'm working on a CR at the moment, but I will prioritize this ASAP.