Skip to content

refactor: init to support external storage for history tables #18185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Jun 18, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

part of #18146

Due to the size of the changes, I’ve decided to split the feature into two separate PRs.

This is the first one, which includes:

  • Extracting StorageParams from databend-common-meta-app. The tracing library cannot depend on databend-common-meta-app to avoid a cyclic dependency.
  • Adding a new configuration subsection for history tables: [log.history.storage]
  • Refactor to split meta related operations out from GlobalHistoryLog
  • Use RAII pattern's Guard to update last acquire's timestamp
  • Change history table's default level from WARN to INFO

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - No feature change, just refactor

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jun 18, 2025
@dqhl76 dqhl76 force-pushed the external-storage-1 branch from 71f22df to a378620 Compare June 18, 2025 08:06
@dqhl76 dqhl76 marked this pull request as ready for review June 18, 2025 08:41
@dqhl76 dqhl76 requested a review from zhang2014 June 18, 2025 08:55
@dqhl76 dqhl76 force-pushed the external-storage-1 branch from 6e0c871 to 6ca4558 Compare June 18, 2025 09:11
@zhang2014 zhang2014 merged commit 28aa33b into databendlabs:main Jun 18, 2025
78 checks passed
@dqhl76 dqhl76 deleted the external-storage-1 branch June 18, 2025 11:16
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants