Skip to content

fix(query): add_months need to respect last day of month #18201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(query): add_months need to respect last day of month #18201

wants to merge 1 commit into from
+122 −21

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jun 20, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

ADD_MONTHS returns slightly different results than DATEADD used with a MONTH component:

  • For both ADD_MONTHS and DATEADD, if the result month has fewer days than the original day, the result day of the month is the last day of the result month.

  • For ADD_MONTHS only, if the original day is the last day of the month, the result day of month will be the last day of the result month.

In main:

select add_months('2025-04-30',1)
----
2025-05-30

In PR:

select add_months('2025-04-30',1)
----
2025-05-31

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason marked this pull request as draft June 20, 2025 04:48
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jun 20, 2025
@TCeason
fix(query): add_months need to respect last day of month
de15023 
ADD_MONTHS returns slightly different results than DATEADD used with a MONTH component:

For both ADD_MONTHS and DATEADD, if the result month has fewer days than the original day, the result day of the month is the last day of the result month.

For ADD_MONTHS only, if the original day is the last day of the month, the result day of month will be the last day of the result month.

In main:

```sql
select add_month('2025-04-30',1)
----
2025-05-30
```

In PR:

```sql
select add_month('2025-04-30',1)
----
2025-05-31
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: add_months need to respect last day of month
1 participant
@TCeason