-
Notifications
You must be signed in to change notification settings - Fork 114
Chunk download latency #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sea-migration
Are you sure you want to change the base?
Conversation
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
@jayantsing-db can you take a look, this PR adds latency logs (merges into sea-migration) as there are some refactorings that this PR leverages |
Signed-off-by: Sai Shree Pradhan <[email protected]>
src/databricks/sql/client.py
Outdated
@@ -1060,7 +1070,7 @@ def tables( | |||
) | |||
return self | |||
|
|||
@log_latency(StatementType.METADATA) | |||
@log_latency() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel why is the code modified to fit telemetry? like the statement type within log latency decorator made sense. Why is it now a part of the statement type in the code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chunk downloader function doesn't know the StatementType
, hence had to pass it down as arg.
Now have changed it to always set statement_type
to StatementType.QUERY
as metadata does not use cloud fetch.
@@ -63,6 +63,10 @@ def test_initializer_adds_links(self, mock_create_next_table): | |||
result_links=result_links, | |||
max_download_threads=10, | |||
ssl_options=SSLOptions(), | |||
session_id_hex=Mock(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikrantpuppala I think we should introduce some variables like the connection context in JDBC .
- Passing these variables in so many functions is just bloating the code. A future TODO
- This will also simply the TelemetryExtractor:
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
What type of PR is this?
Description
Record chunk download latency
Added
chunk_id
toSqlExecutionEvent
andResultDownloadHandler
How is this tested?
Ran the query:
SELECT * FROM RANGE(20000000)
Latency was recorded for 4 chunks.
The latency log for the 1st chunk:
Related Tickets & Documents