Build fails on macOS 12.3.1 (since python 2.7 is removed in that version)

[storyalex]

Title says it all.

$ cargo b
   Compiling sentry-contrib-native-sys v0.3.1
error: failed to run custom build command for `sentry-contrib-native-sys v0.3.1`

Caused by:
  process didn't exit successfully: `/Users/alex/***/target/debug/build/sentry-contrib-native-sys-2c5dda3f75ccf618/build-script-build` (exit status: 101)
  --- stdout
  CMAKE_TOOLCHAIN_FILE_x86_64-apple-darwin = None
  CMAKE_TOOLCHAIN_FILE_x86_64_apple_darwin = None
  HOST_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_x86_64-apple-darwin = None
  CMAKE_GENERATOR_x86_64_apple_darwin = None
  HOST_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_x86_64-apple-darwin = None
  CMAKE_PREFIX_PATH_x86_64_apple_darwin = None
  HOST_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_x86_64-apple-darwin = None
  CMAKE_x86_64_apple_darwin = None
  HOST_CMAKE = None
  CMAKE = None
  running: "cmake" "/Users/alex/.cargo/registry/src/git.godevs.top-1ecc6299db9ec823/sentry-contrib-native-sys-0.3.1/sentry-native" "-DBUILD_SHARED_LIBS=OFF" "-DSENTRY_BUILD_TESTS=OFF" "-DSENTRY_BUILD_EXAMPLES=OFF" "-DSENTRY_BACKEND=crashpad" "-DCRASHPAD_ZLIB_SYSTEM=OFF" "-DCMAKE_INSTALL_PREFIX=/Users/alex/***/target/debug/build/sentry-contrib-native-sys-446c26c5e4b0dd0c/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=RelWithDebInfo"
  -- SENTRY_TRANSPORT=curl
  -- SENTRY_BACKEND=crashpad
  -- SENTRY_LIBRARY_TYPE=STATIC
  -- Configuring incomplete, errors occurred!
  See also "/Users/alex/***/target/debug/build/sentry-contrib-native-sys-446c26c5e4b0dd0c/out/build/CMakeFiles/CMakeOutput.log".
  See also "/Users/alex/***/target/debug/build/sentry-contrib-native-sys-446c26c5e4b0dd0c/out/build/CMakeFiles/CMakeError.log".

  --- stderr
  CMake Error at /usr/local/Cellar/cmake/3.23.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) (Required is at
    least version "2.7")
  Call Stack (most recent call first):
    /usr/local/Cellar/cmake/3.23.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    /usr/local/Cellar/cmake/3.23.0/share/cmake/Modules/FindPythonInterp.cmake:169 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    external/crashpad/util/CMakeLists.txt:354 (find_package)

I think it's fixed in upstream getsentry/sentry-native repo, but I'm not sure how to bump it in here.
Let me know if you need more info or testing!

• OS: macOS 12.3.1
• Rust 1.58.1 (db9d1b20b 2022-01-20)

[daxpedda]

Sorry, was sick for a while. I'm still in the process on catching up on all the things.

Preferably my whole crate will become obsolete with getsentry/sentry-rust#469. But if it's not done until I catch up to this issue, I will update.

Just to get some feedback, would getsentry/sentry-rust#469 solve your issue @storyalex.

[storyalex]

I think we can move to that package after getsentry/sentry-rust#469 is solved, but that issue does not solve the build problem on osx (per se). The build problem in CI for that issue on OSX is not the same as we get for this repo (If that's what you meant).

I fully understand if this is never resolved, tbqh it doesn't really matter to us since we don't send reports from macOS generally.

Hope you got well from your sickness and thanks for your work on this project!

[daxpedda]

I think we can move to that package after getsentry/sentry-rust#469 is solved, but that issue does not solve the build problem on osx (per se). The build problem in CI for that issue on OSX is not the same as we get for this repo (If that's what you meant).

Oh, I didn't look properly at that PR when I linked it, from the OP I thought it's about integrating the new pure-Rust breakpad alternative. See minidump-writer, crash-handling and sentry-rust-minidump, the last one being used with getsentry/sentry-rust#469.

Moving to minidump-writer should definitely solve the OSX issue ;). But I guess there is no direct work being done integrating that into sentry-rust yet.

[timfish]

Sentry published a Rust release including my attachments PR so I was able to publish sentry-rust-minidump. It mainly just hooks up minidump-writer and crash-handling as per their examples.

But I guess there is no direct work being done integrating that into sentry-rust yet.

I did try getting it working as a Sentry integration as that would be the cleanest way to extend sentry-rust but I either ran out of talent or it's not possible with the current integrations API.

The PR linked above would allow basic synchronisation of breadcrumbs and scope to the crash reporting process so they're included with minidump events too.

[daxpedda]

Nice progress anyhow. Let's hope it continues. Good work so far!