-
Notifications
You must be signed in to change notification settings - Fork 883
remove the dependency of gdrcopy #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -435,3 +435,40 @@ index c89f408..f99018a 100644 | |
|
||
return NVSHMEMX_ERROR_INTERNAL; | ||
} | ||
|
||
|
||
From 099f608fcd9a1d34c866ad75d0af5d02d2020374 Mon Sep 17 00:00:00 2001 | ||
From: Kaichao You <[email protected]> | ||
Date: Tue, 10 Jun 2025 00:35:03 -0700 | ||
Subject: [PATCH] remove gdrcopy dependency | ||
|
||
--- | ||
src/modules/transport/ibgda/ibgda.cpp | 6 ++++++ | ||
1 file changed, 6 insertions(+) | ||
|
||
diff --git a/src/modules/transport/ibgda/ibgda.cpp b/src/modules/transport/ibgda/ibgda.cpp | ||
index ef325cd..16ee09c 100644 | ||
--- a/src/modules/transport/ibgda/ibgda.cpp | ||
+++ b/src/modules/transport/ibgda/ibgda.cpp | ||
@@ -406,6 +406,7 @@ static size_t ibgda_get_host_page_size() { | ||
return host_page_size; | ||
} | ||
|
||
+#ifdef NVSHMEM_USE_GDRCOPY | ||
int nvshmemt_ibgda_progress(nvshmem_transport_t t) { | ||
nvshmemt_ibgda_state_t *ibgda_state = (nvshmemt_ibgda_state_t *)t->state; | ||
int n_devs_selected = ibgda_state->n_devs_selected; | ||
@@ -459,6 +460,11 @@ int nvshmemt_ibgda_progress(nvshmem_transport_t t) { | ||
} | ||
return 0; | ||
} | ||
+#else | ||
+int nvshmemt_ibgda_progress(nvshmem_transport_t t) { | ||
+ return NVSHMEMX_ERROR_NOT_SUPPORTED; | ||
+} | ||
+#endif | ||
|
||
int nvshmemt_ibgda_show_info(struct nvshmem_transport *transport, int style) { | ||
NVSHMEMI_ERROR_PRINT("ibgda show info not implemented"); | ||
-- | ||
2.34.1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.