Correcting Export GEO #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergpolly
reviewed
Jun 11, 2020
There was a problem hiding this comment.
I'm "done" with my review ...
I honestly do not understand much here, but it would be nice if @Snehal1894 you could provide some comments here, such that we could track which code-changes is related to which of the bugs and new features
once we're done with that we'll merge it, assuming it actually works ))
PS edits:
oh wow ! I found a bunch of relevant issue on the issues page!
we should use them when commenting to this PR - which code changes correspond to which issue ...
I'll also post @betulakgol 's emails regarding DCIC issue - such that it is documented as well!
Snehal1894
commented
Jun 11, 2020
This was referenced Jun 12, 2020
sergpolly
reviewed
Jun 12, 2020
|
Awesome stuff @Snehal1894 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
if conditionforEnzyme nameandchoice namein the code.This is where it was giving error.