Skip to content

Added requirements.txt for ReadTheDocs #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Feb 21, 2022

Description of the Change

Flake8 and Spinx cannot be installed together anymore as of a conflict with importlib-metadata package.

As RTD only supports one requirements.txt file we need a separate one where only the dependencies for creation of documentation are installed.

This should solve this RTD build error.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Flake8 and Spinx cannot be installed together anymore as of conflict
with importlib-metadata package.

As RTD only supports one requirements.txt file we need a separate
one where only the dependencies for creation of documentation
are installed.
@sliverc sliverc requested a review from n2ygk February 21, 2022 17:12
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n2ygk n2ygk merged commit 646d2a1 into django-json-api:main Feb 21, 2022
@sliverc sliverc deleted the reqs_for_rtd branch February 21, 2022 18:43
@sliverc
Copy link
Member Author

sliverc commented Feb 22, 2022

Great. Adjusted RTD settings and build seems to work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants