Skip to content

Add <version> to all variant sections so that they won't be confused as actual tags #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .template-helpers/variant-alpine.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:alpine`
## `%%IMAGE%%:<version>-alpine`

This image is based on the popular [Alpine Linux project](http://alpinelinux.org), available in [the `alpine` official image](https://hub.docker.com/_/alpine). Alpine Linux is much smaller than most distribution base images (~5MB), and thus leads to much slimmer images in general.

Expand Down
2 changes: 1 addition & 1 deletion .template-helpers/variant-onbuild.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:onbuild`
## `%%IMAGE%%:<version>-onbuild`

The `ONBUILD` image variants are deprecated, and their usage is discouraged. For more details, see [docker-library/official-images#2076](https://github.com/docker-library/official-images/issues/2076).

Expand Down
2 changes: 1 addition & 1 deletion .template-helpers/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%IMAGE%%:slim`
## `%%IMAGE%%:<version>-slim`

This image does not contain the common packages contained in the default tag and only contains the minimal packages needed to run `%%IMAGE%%`. Unless you are working in an environment where *only* the `%%IMAGE%%` image will be deployed and you have space constraints, we highly recommend using the default image of this repository.
2 changes: 1 addition & 1 deletion .template-helpers/variant-windowsservercore.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:windowsservercore`
## `%%IMAGE%%:<version>-windowsservercore`

This image is based on [Windows Server Core (`microsoft/windowsservercore`)](https://hub.docker.com/r/microsoft/windowsservercore/). As such, it only works in places which that image does, such as Windows 10 Professional/Enterprise (Anniversary Edition) or Windows Server 2016.

Expand Down
2 changes: 1 addition & 1 deletion openjdk/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%IMAGE%%:slim`
## `%%IMAGE%%:<version>-slim`

This image installs the `-headless` package of OpenJDK and so is missing many of the UI-related Java libraries and some common packages contained in the default tag. It only contains the minimal packages needed to run Java. Unless you are working in an environment where *only* the `%%IMAGE%%` image will be deployed and you have space constraints, we highly recommend using the default image of this repository.
9 changes: 0 additions & 9 deletions python/variant-onbuild.md

This file was deleted.

2 changes: 1 addition & 1 deletion znc/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%REPO%%:slim`
## `%%REPO%%:<version>-slim`

This image is smaller, but it doesn't support external modules. If you need any external C++, Perl or Python module, use `latest` instead of `slim`.