Skip to content

seed scripts not readable by effective user mysql when mounted volume #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

seed scripts not readable by effective user mysql when mounted volume #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9404e5
strip trailing whack from DATADIR
qrkourier May 18, 2018
de5f484
also recursively chown initdb.d dir because if mounted volume the scr…
qrkourier May 18, 2018
72b0728
set working dir so we can use relative path to executable which avoid…
qrkourier May 18, 2018
d16aaed
let the symlink target be absolute
qrkourier May 18, 2018
3db92ad
source seed scripts from a copy of the initdb.d dir because EID mysql…
qrkourier May 18, 2018
a428f8c
fixup read+execute filemode on entrypoint
qrkourier May 18, 2018
c7fdd8a
try several keyservers because gosu intermittently fails with "unable…
qrkourier May 19, 2018
ce3d39b
Merge branch 'master' of https://github.com/docker-library/mysql
qrkourier Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions 5.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ RUN set -ex; \
# gpg: key 5072E1F5: public key "MySQL Release Engineering <[email protected]>" imported
key='A4A9406876FCBD3C456770C88C718D3B5072E1F5'; \
export GNUPGHOME="$(mktemp -d)"; \
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
for keyserver in $(shuf -e \
ha.pool.sks-keyservers.net \
hkp://p80.pool.sks-keyservers.net:80 \
keyserver.ubuntu.com \
hkp://keyserver.ubuntu.com:80 \
pgp.mit.edu) ; do \
gpg --keyserver $keyserver --recv-keys "$key" && break || true ; \
done && \
gpg --export "$key" > /etc/apt/trusted.gpg.d/mysql.gpg; \
gpgconf --kill all; \
rm -rf "$GNUPGHOME"; \
Expand Down Expand Up @@ -72,9 +79,11 @@ RUN { \

VOLUME /var/lib/mysql

COPY docker-entrypoint.sh /usr/local/bin/
RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat
ENTRYPOINT ["docker-entrypoint.sh"]
WORKDIR /usr/local/bin
COPY ./docker-entrypoint.sh .
RUN chmod 0755 ./docker-entrypoint.sh
RUN ln -s /usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat
ENTRYPOINT ["./docker-entrypoint.sh"]

EXPOSE 3306
CMD ["mysqld"]
13 changes: 8 additions & 5 deletions 5.7/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,11 @@ _get_config() {
if [ "$1" = 'mysqld' -a -z "$wantHelp" -a "$(id -u)" = '0' ]; then
_check_config "$@"
DATADIR="$(_get_config 'datadir' "$@")"
mkdir -p "$DATADIR"
chown -R mysql:mysql "$DATADIR"
# seed scripts from a copy of the initdb.d dir because EID mysql may not have permission to read
# a docker volume mounted on the usual initdb.d path
mkdir -p "$DATADIR" /etc/mysql/initdb.d/
cp -RT /docker-entrypoint-initdb.d /etc/mysql/initdb.d
chown -R mysql:mysql "$DATADIR" /etc/mysql/initdb.d/
exec gosu mysql "$BASH_SOURCE" "$@"
fi

Expand All @@ -95,7 +98,7 @@ if [ "$1" = 'mysqld' -a -z "$wantHelp" ]; then
# Get config
DATADIR="$(_get_config 'datadir' "$@")"

if [ ! -d "$DATADIR/mysql" ]; then
if [ ! -d "${DATADIR%/}/mysql" ]; then
file_env 'MYSQL_ROOT_PASSWORD'
if [ -z "$MYSQL_ROOT_PASSWORD" -a -z "$MYSQL_ALLOW_EMPTY_PASSWORD" -a -z "$MYSQL_RANDOM_ROOT_PASSWORD" ]; then
echo >&2 'error: database is uninitialized and password option is not specified '
Expand Down Expand Up @@ -191,8 +194,8 @@ if [ "$1" = 'mysqld' -a -z "$wantHelp" ]; then
fi

echo
ls /docker-entrypoint-initdb.d/ > /dev/null
for f in /docker-entrypoint-initdb.d/*; do
ls /etc/mysql/initdb.d/ > /dev/null
for f in /etc/mysql/initdb.d/*; do
process_init_file "$f" "${mysql[@]}"
done

Expand Down