Add "/entrypoint.sh" backwards-compat symlink in Oracle-based images #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Jul 8, 2022
| @@ -130,6 +130,9 @@ RUN set -eux; \ | |||
| VOLUME /var/lib/mysql | |||
|
|
|||
| COPY docker-entrypoint.sh /usr/local/bin/ | |||
| {{ if [ "5.7", "8.0" ] | index(env.version) then ( -}} | |||
| RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat | |||
There was a problem hiding this comment.
Should this use an absolute path? (just to be sure / explicit)?
Suggested change
| RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat | |
| RUN ln -s /usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat |
There was a problem hiding this comment.
(I guess the image would unlikely get a WORKDIR changed/set, but if it would..)
There was a problem hiding this comment.
🤷 it's put in the root, and this matches the Debian version 😇
There was a problem hiding this comment.
(Semi-intentional that it's not "pretty" so that we definitely get rid of it later 👀)
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jul 11, 2022
Changes: - docker-library/mysql@2e83286: Merge pull request docker-library/mysql#885 from infosiftr/entrypoint-back-compat - docker-library/mysql@ea98f69: Add "/entrypoint.sh" backwards-compat symlink in Oracle-based images
BaurzhanSakhariev
pushed a commit
to crate/official-images
that referenced
this pull request
Jul 18, 2022
Changes: - docker-library/mysql@2e83286: Merge pull request docker-library/mysql#885 from infosiftr/entrypoint-back-compat - docker-library/mysql@ea98f69: Add "/entrypoint.sh" backwards-compat symlink in Oracle-based images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884
Thanks for the report, @martynd! ❤️