Skip to content

Honour http_proxy env variable when fetching gpg keys #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hbog
Copy link

@hbog hbog commented Jul 28, 2018

http_proxy can be defined as build argument when building the
container behind a proxy.
Since version 2.1 of GnuPG, dirmngr takes care of accessing keyservers,
but dirnmgr does not honor http_proxy unless it is configured to do so.
Therefore building the container behind a firewall fails since the base image
was switched from debian/jessie to debian/stretch.

@tianon
Copy link
Member

tianon commented Jul 30, 2018

I'm curious why you're rebuilding instead of simply using the pre-built artifacts; can you explain your use case a little bit?

@hbog
Copy link
Author

hbog commented Jul 31, 2018

I have built customized base images that contain a few location specific settings, such as our locale. Hence location specific image extensions are done only once in a base image, rather then writing an extension for every type of container. This generates localized images using universal, portable build scripts. I submitted a PR because I can image that there might be other reasons for not using the pre-built artifacts.

http_proxy can be defined as build argument when building the
container behind a proxy.
Since version 2.1 of GnuPG, dirmngr takes care of accessing keyservers,
but dirnmgr does not honor http_proxy unless it is configured to do so.
@tianon
Copy link
Member

tianon commented Jun 23, 2020

Closing given none of our build environments use a proxy in such an explicit way. There are also some notes in https://github.com/docker-library/faq#openpgp--gnupg-keys-and-verification which could be used to accomplish this without too much overhead (hijacking container DNS to point to a proxy-aware reverse proxy for these requests).

For what it's worth, things like added locales would more easily be handled via something like:

FROM postgres:xxx
RUN localedef -i de_DE -c -f UTF-8 -A /usr/share/locale/locale.alias de_DE.UTF-8
ENV LANG de_DE.utf8

(as noted under "Locale Customization" on https://hub.docker.com/_/postgres)

@tianon tianon closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants