Is PROFILE_TASK actually used in the Dockerfile?

[RobertDeRose]

I see that in the history of the linux template, that PROFILE_TASK was specifically set to a value and used across both invocation of make. However, I downloaded the 3.12.7 and 3.13.0 Dockerfiles to understand what it going on, and I enabled Docker's full logging and noticed that the profiling step does not get invoked.

It appears that this variable is now "" and then the Makefile just skips the step, thus essentially disabling the --enabled-optimization flag.

If someone could just confirm my findings and ensure I am not missing something, that would be awesome.

Thanks!

[yosifkit]

Doh, yeah that is causing it to skip the optimizations 😢. Now that none of the python versions need PROFILE_TASK, we can just drop it out of the template and apply the results (rather than having to conditionalize it in the template). Looks like it was missed when PROFILE_TASK was moved around in #794.

[edmorley]

Wouldn't the test -z here ignore PROFILE_TASK if set to the empty string, and so continue to use the default task in that case?
https://github.com/python/cpython/blob/37e533a39716bf7da026eda2b35073ef2eb3d1fb/configure.ac#L1905

[edmorley]

(but either way, passing in PROFILE_TASK is dead code now and can be removed :-) )

[yosifkit]

Yeah, but we're setting for the make invocation, which doesn't look for empty

python/3.13/bookworm/Dockerfile

Lines 53 to 56 in 7666104

	make -j "$nproc" \
	"EXTRA_CFLAGS=${EXTRA_CFLAGS:-}" \
	"LDFLAGS=${LDFLAGS:-}" \
	"PROFILE_TASK=${PROFILE_TASK:-}" \

https://github.com/python/cpython/blob/37e533a39716bf7da026eda2b35073ef2eb3d1fb/Makefile.pre.in#L330

[RobertDeRose]

Oh, glad I am not crazy, I can open a PR for this.

[yosifkit]

That'd be great. Thank you!