bundler error with any gem from git

[ivan-kolmychek]

When I have gems, spefcified in gemfile with:git, running container fails with bundler error.

Gemfile:

# secure token auth for devise
gem 'simple_token_authentication', git: 'https://github.com/gonzalo-bulnes/simple_token_authentication.git'

Error:

[ivko@thinkpad-e530 test]$ docker run -p 3000 --link test-postgres:postgres test
/usr/local/lib/ruby/gems/2.1.0/gems/bundler-1.7.3/lib/bundler/source/git/git_proxy.rb:151:
in `allowed_in_path': The git source https://github.com/gonzalo-bulnes/simple_token_authentication.git
is not yet checked out. Please run `bundle install` before trying to start your application 
(Bundler::GitError)

Some Stack overflow answers suggest to use --path bundler option.

[ivan-kolmychek]

--path option alone does not helps, but switching commands with ADD ADD . /usr/src/app does.
So, the way it worked for me:

# based on https://github.com/docker-library/rails
FROM rails:4.1.6
MAINTAINER Ivan Kolmychek <ivan.kolmychek@gmail.com> 
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
ADD Gemfile /usr/src/app/
ADD Gemfile.lock /usr/src/app/
ADD . /usr/src/app
RUN bundle install --system
EXPOSE 3000
CMD ["rails", "server"]

and suggested workaround for onbuild Dockerfile:

ONBUILD ADD Gemfile /usr/src/app/
ONBUILD ADD Gemfile.lock /usr/src/app/
ONBUILD ADD . /usr/src/app
ONBUILD RUN bundle install --system

Is there any things that require that bundle install should be run before adding an app source?

[yosifkit]

The onbuild works for most rails apps, but does not work for apps with gemspec. The reason we only add Gemfile and Gemfile.lock before bundle install is to use Docker caching so that code changes do not trigger a reinstall of all the gems. Copying the onbuid directives into your dockerfile with your extra steps is currently the only solution for these complex setups.

This is related to docker-library/ruby#16 and docker-library/ruby#19.

[ivan-kolmychek]

@yosifkit Thank you for the reply. I think, we should put it into the docs/readme, at least for now.

[ivan-kolmychek]

Excuse me, please, closed by pressing wrong button. =)

[yosifkit]

Is this related to having a local .bundle directory that gets ADDed in the ONBUILD?

[ivan-kolmychek]

@yosifkit I'm not sure, but I'll check it out now.

I have these records in .dockerignore:

.bundle
.git
vendor/bundle
Vagrantfile
puppet

[ivan-kolmychek]

@yosifkit No, even when I remove .bundle directory from original source, it still gets removed on copy as well.

Running second bundle install --system with onbuild FROM proves to be very lightweight, because all main gems are already cached and installed, so, it pulls only "lost" gems (i.e. from :git).

So, result:

#!/bin/env ruby
# based on https://github.com/docker-library/rails

FROM rails:onbuild

MAINTAINER Ivan Kolmychek <ivan.kolmychek@gmail.com> 

RUN bundle install --system

[ivan-kolmychek]

I think, we should add note about this to docs and issue may be considered closed. =)