Skip to content

Use same language set for .wxl and .json files (#43888) #43930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 12, 2022

  • translation infrastructure works better when Projects elements use same languages
    • previous use of two+two codes were an unnecessary complication and cover the same languages
  • WiX_CloneLanguages already updated on loc side to use the default two-letter language codes

- translation infrastructure works better when `Projects` elements use same languages
  - previous use of two+two codes were an unnecessary complication and cover the same languages
- `WiX_CloneLanguages` already updated on loc side to use the default two-letter language codes
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 12, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Sep 12, 2022

cherry-picked 349ddc9 back because #43916 overwrote what I did in #43888 on Friday. Arcade validation process must have held up my dotnet/arcade@6b6da366e6c3dc changes ☹️

@dougbu
Copy link
Contributor Author

dougbu commented Sep 12, 2022

Merging immediately since PR validation won't check anything related to these changes

@dougbu dougbu merged commit 89160ad into dotnet:main Sep 12, 2022
@dougbu dougbu deleted the dougbu/redo.wxl.loc.fix branch September 12, 2022 21:27
@ghost ghost added this to the 8.0-preview1 milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants