Skip to content

[release/10.0-preview6] Flip switch for controlling navigation flow on SSR #62377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 17, 2025

Backport of #62358 and partial #62369 (fixing CI) to release/10.0-preview6

/cc @ilonatommy

Flip switch for controlling navigation flow on SSR

Flips the App switch for controlling the navigation flow on SSR.

Description

Switch was introduced in #61306. The PR unifies the navigation across render modes but also allows SSR code after the navigation to run. Upgrading the application could lead to unexpected behaviors, e.g. see how templates had to be changed to adjust to the new navigation: #62105. From this reason, we decided to keep the default behavior for the exception flow. It can be changed by setting Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException switch. New projects will use the new way of working.

Partial backport of #62369 fixes the tests that are failing on p6 branch. It was introduced in #62045. The CI was green but inside, the non-quaratined test silently failed log.

Customer Impact

It will keep the behavior same as net9, without the need to change code if users upgrade to net10.

The partial backport changes only test to let this PR merge. Tell mode.

Regression?

  • Yes
  • No

We introduced it with #61306 that was fixing the SSR navigation.

Risk

  • High
  • Medium
  • Low

It's just changing the default behavior to the one from before the fix.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions github-actions bot requested a review from a team as a code owner June 17, 2025 13:53
@ilonatommy ilonatommy requested review from lewing and javiercn June 17, 2025 13:57
@ilonatommy ilonatommy self-assigned this Jun 17, 2025
@ilonatommy ilonatommy added the area-blazor Includes: Blazor, Razor Components label Jun 17, 2025
@ilonatommy ilonatommy added this to the 10.0-preview6 milestone Jun 17, 2025
@ilonatommy
Copy link
Member

CI failures will be fixed with #62369.

@ilonatommy
Copy link
Member

Failures are random and at each attempt a different test fails.

Microsoft.AspNetCore.Routing.Internal.RequestDelegateFactoryTests.RequestDelegateFactory_WhenJsonIsReflectionEnabledByDefaultTrue [FAIL]
   Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Half-way through waiting for remote process.
Microsoft.AspNetCore.Server.HttpSys.Listener.AuthenticationOnExistingQueueTests_Attach.AuthTypes_RequireAuth_Success(authType: Negotiate) [FAIL]
   System.TimeoutException : AcceptAsync has timed out.
Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.RedisEndToEndTests.HubConnectionCanSendAndReceiveGroupMessages(transportType: LongPolling, protocolName: "json")
   System.Exception : Command '/usr/bin/docker run --rm -p 6379:6379 --name redisTestContainer -d redis' failed with exit code '127'. Output:
       Unable to find image 'redis:latest' locally
       latest: Pulling from library/redis
       dad67da3f26b: Pulling fs layer
       b90a44fe26dc: Pulling fs layer
       11c0ea983116: Pulling fs layer
       4bce6440352d: Pulling fs layer
       093c29d9fea9: Pulling fs layer
       4f4fb700ef54: Pulling fs layer
       b222156a9022: Pulling fs layer
       docker: open /datadisks/disk1/docker/tmp/GetImageBlob188582468: no such file or directory.
       See 'docker run --help'.

@ilonatommy
Copy link
Member

ilonatommy commented Jun 19, 2025

/ba-g failures not connected

edit: no, it does not work on backports...

@ilonatommy
Copy link
Member

@javiercn, can we force merge?

@lewing lewing added the Servicing-consider Shiproom approval is required for the issue label Jun 19, 2025
@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jun 19, 2025
@lewing
Copy link
Member

lewing commented Jun 19, 2025

@wtgodbe can you take care of merging this please

@joperezr
Copy link
Member

Merging as @lewing confirmed that the failures here are unrelated and we want to get this in sooner rather than later to make it into P6.

@joperezr joperezr merged commit 56cfc38 into release/10.0-preview6 Jun 19, 2025
23 of 26 checks passed
@joperezr joperezr deleted the backport/pr-62358-to-release/10.0-preview6 branch June 19, 2025 19:00
@dotnet-policy-service dotnet-policy-service bot modified the milestone: 10.0-preview6 Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants