Skip to content

Fix Microsoft.Extensions.Caching.Hybrid repo origin and CoherentParentDependency #62663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

akoeplinger
Copy link
Member

The Microsoft.Extensions.Caching.Hybrid package is built in dotnet/extensions. It's also a toolset dependency (we can only use it in tests) so move it to the appropriate section.

We also noticed that the darc updates were broken due to the CoherentParentDependency on the optimization packages, which no longer works since there's no aspnetcore->runtime dependency anymore with the VMR.

…s.xml

That package is built in dotnet/extensions. It's also a toolset dependency (we can only use it in tests) so move it to the appropriate section.
@akoeplinger akoeplinger requested review from wtgodbe and a team as code owners July 10, 2025 16:37
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 10, 2025
@akoeplinger
Copy link
Member Author

@javiercn FYI this answers your question from #62299 (review) 😄

@akoeplinger akoeplinger enabled auto-merge (squash) July 10, 2025 16:48
@akoeplinger akoeplinger merged commit 402bfbb into main Jul 10, 2025
28 checks passed
@akoeplinger akoeplinger deleted the fix-extensions-hybrid branch July 10, 2025 18:50
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 10, 2025
@BrennanConroy
Copy link
Member

It's also a toolset dependency (we can only use it in tests)

It's used in product code.

private readonly HybridCache? _hybridCache;

@javiercn
Copy link
Member

javiercn commented Jul 10, 2025

@BrennanConroy nope. That's the abstraction that lives in runtime and is part of the BCL, not the cache package.

@akoeplinger
Copy link
Member Author

Yeah I got confused about that a bit first as well because of the namespace. But the abstraction lives in https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCache.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants