Skip to content

Add documentation for dotnet nuget config commands #41019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2024
Merged

Add documentation for dotnet nuget config commands #41019

merged 4 commits into from
Jun 3, 2024

Conversation

martinrrm
Copy link
Contributor

@martinrrm martinrrm commented May 20, 2024 •
edited by github-actions bot
Loading

@martinrrm martinrrm requested a review from tdykstra as a code owner May 20, 2024 21:54
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 20, 2024
@martinrrm martinrrm mentioned this pull request May 20, 2024
Closed
tdykstra
tdykstra reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several markdownlint errors need to be addressed:
Error: docs/core/tools/dotnet-nuget-config-get.md:40:1 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/core/tools/dotnet-nuget-config-get.md:65:62 MD047/single-trailing-newline Files should end with a single newline character
Error: docs/core/tools/dotnet-nuget-config-paths.md:27 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Error: docs/core/tools/dotnet-nuget-config-paths.md:52:62 MD047/single-trailing-newline Files should end with a single newline character
Error: docs/core/tools/dotnet-nuget-config-set.md:25:30 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/core/tools/dotnet-nuget-config-set.md:61:62 MD047/single-trailing-newline Files should end with a single newline character
Error: docs/core/tools/dotnet-nuget-config-unset.md:25:32 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/core/tools/dotnet-nuget-config-unset.md:33 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Error: docs/core/tools/dotnet-nuget-config-unset.md:58:62 MD047/single-trailing-newline Files should end with a single newline character

@tdykstra tdykstra self-requested a review May 21, 2024 18:30
tdykstra
tdykstra reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a few suggestions for minor fixes.

@BillWagner
Copy link
Member

Hi @martinrrm

Can you address the review comments?

@martinrrm martinrrm requested a review from tdykstra June 3, 2024 21:21
tdykstra
tdykstra approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdykstra tdykstra merged commit d52c787 into main Jun 3, 2024
8 checks passed
@tdykstra tdykstra deleted the martinrrm-dotnet-nuget-config-docs branch June 3, 2024 23:51
@gewarren
Copy link
Contributor

Oops, these weren't added to the TOC.

@gewarren gewarren mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees

@tdykstra tdykstra

Labels
dotnet-cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Document dotnet nuget config
5 participants
@martinrrm @BillWagner @gewarren @tdykstra @dotnet-bot