-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix ObjectToInferredTypesConverter stack overflow when serializing plain object #46893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue Co-authored-by: gewarren <[email protected]>
…ject Co-authored-by: gewarren <[email protected]>
Copilot finished work on behalf of
gewarren
June 19, 2025 11:47
BillWagner
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @gewarren
Once you and @eiriktsarpalis agree on the style suggestion, go ahead and
...zation/system-text-json/snippets/how-to-contd/csharp/CustomConverterInferredTypesToObject.cs
Outdated
Show resolved
Hide resolved
…able Co-authored-by: BillWagner <[email protected]>
auto-merge was automatically disabled
June 19, 2025 16:02
Head branch was pushed to by a user without write access
Copilot finished work on behalf of
BillWagner
June 19, 2025 16:03
...zation/system-text-json/snippets/how-to-contd/csharp/CustomConverterInferredTypesToObject.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: eiriktsarpalis <[email protected]>
Copilot finished work on behalf of
eiriktsarpalis
June 19, 2025 16:46
eiriktsarpalis
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ObjectToInferredTypesConverter
in the JSON serialization documentation was causing a stack overflow when attempting to serialize a plainobject
instance (e.g.,new object()
).Problem
The issue occurred in the
Write
method:When
objectToWrite
is a plainobject
instance,objectToWrite.GetType()
returnstypeof(object)
, which causes the converter to recursively call itself indefinitely, resulting in a stack overflow.Solution
Added a check for
typeof(object)
in theWrite
method. When the object type is exactlyobject
, the method now writes an empty JSON object{}
instead of recursively callingJsonSerializer.Serialize
:Testing
new object()
serialization (now produces{}
)This is a minimal, surgical fix that addresses the specific issue without breaking any existing functionality.
Fixes #43831.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.