Skip to content

Deprecate AddServiceLogEnricher method with its overloads, introduce replacements #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deprecate AddServiceLogEnricher method with its overloads, introduce replacements #6529

wants to merge 2 commits into from

Conversation

evgenyfedorov2
Copy link
Member

@evgenyfedorov2 evgenyfedorov2 commented Jun 20, 2025 •
edited
Loading

Resolves #6532

@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/fix_service_enricher_api branch from bbc09ed to ed2d9bc Compare June 23, 2025 08:08
@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/fix_service_enricher_api branch from ed2d9bc to 79e5bec Compare June 23, 2025 08:10
@evgenyfedorov2 evgenyfedorov2 marked this pull request as ready for review June 23, 2025 08:10
@evgenyfedorov2 evgenyfedorov2 requested review from a team as code owners June 23, 2025 08:10
@evgenyfedorov2 evgenyfedorov2 changed the title Rename service log enricher public API Deprecate AddServiceLogEnricher method with its overloads, introduce replacements Jun 23, 2025
@evgenyfedorov2
Copy link
Member Author

@joperezr please review for dotnet-extensions-infra. This is not a breaking change yet, just a normal process of introducing new API instead of old

@joperezr
Copy link
Member

@joperezr please review for dotnet-extensions-infra. This is not a breaking change yet, just a normal process of introducing new API instead of old

It is adding obsolete attributes to some APIs which is a breaking change though. Should we delay that till next major version bump?

@evgenyfedorov2 evgenyfedorov2 added the * NO MERGE * Do not merge this PR as long as this label is present. label Jun 27, 2025
@evgenyfedorov2
Copy link
Member Author

to be merged for 10.0.0 release only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariamgerges mariamgerges mariamgerges approved these changes

Assignees

@evgenyfedorov2 evgenyfedorov2

Labels
area-telemetry * NO MERGE * Do not merge this PR as long as this label is present.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate AddServiceLogEnricher method with its overloads
3 participants
@evgenyfedorov2 @joperezr @mariamgerges