[wasm] Do not use link flags for bitcode compilation #108846
Conversation
Backport of (dotnet#101397) This avoids errors like: /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_ES6' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj] /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_EXCEPTION_HANDLING_HELPERS' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj] This should helps with known build error dotnet#104827 where the warning can hide another errors
ghost
added
the
|
Friendly reminder that today 10/14 is Code Complete for the November Release. If this fix is intended to be included in that release, please make sure it's merged before 4pm PT. Otherwise, it will have to wait until next month. |
|
@lewing what do you think about merging this to release/8.0? it would allow us to cast some light to issues potentially invisible due to known build error issue |
|
@lewing @radekdoulik Friendly reminder that today is Code Complete for the February 2025 Release. Please get a Tactics approval and merge it before 4pm PT, otherwise it would have to wait until next month. |
|
This is infra only, so I marked it servicing-approved. There are new failures though. Are they related? |
|
@radekdoulik please take a look at the PR failures. we can merge when ready |
|
@radekdoulik @lewing Today is code complete for the April Release. If you want this fix included in this release, please merge it before 4pm PT. |
|
@radekdoulik @lewing Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date. |
|
We decided not to take this after all given where we are in the 8.0 cycle. |
Manual backport of (#101397) and (#101538)
Customer Impact
Regression
Risk
Low. Fixes warning during bc files compilation.
Description
This avoids errors like:
This should helps with known build error #104827 where the warning can hide another errors