JIT: Don't show code bytes for loongarch64 disasm unless it was told to do so #112486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
xen0n
reviewed
Feb 14, 2025
There was a problem hiding this comment.
The previous logic seems similar to that of the aarch64 port, except the aarch64 code early-returns on !emitComp->opts.disCodeBytes. We probably want to emit the instruction hex when disCodeBytes && !disDiffable.
|
PTAL |
|
cc @jakobbotsch Can you take a look? |
|
@shushanhf can you also approve? |
shushanhf
approved these changes
Feb 23, 2025
jakobbotsch
approved these changes
Feb 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the same behavior with other architectures. We were using the incorrect knob.