Skip to content

Coretestlib: Add information of parent process id during test failure for Windows #112724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

kunalspathak
Copy link
Member

Over past week, we have seen multiple hangs in windows/arm64 configuration, that doesn't repro locally. We want to understand why the dump of the hung process is not getting created. The parent process tries to iterate over the child processes but doesn't find the desired corerun child process and hence no dump is created. To make sure that the logic around that is correct, this PR adds logging of parent process id as well to make sure our dump collection logic gets triggered at right place.

Reference:

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@kunalspathak
Copy link
Member Author

azp run runtime-coreclr jitstress, runtime-coreclr jitstress2-jitstressregs

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr jitstress2-jitstressregs

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak kunalspathak marked this pull request as ready for review February 20, 2025 21:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs:859

  • The hardcoded wait time of 100 milliseconds might not be sufficient for the process to exit. Consider waiting for the process to exit without a timeout or handling the case where the process takes longer to complete.
process.WaitForExit(100);

src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs:843

  • [nitpick] The method name 'GetAllProcessNames_wmic' should use PascalCase for the acronym, like 'GetAllProcessNamesWmic', to be consistent with C# naming conventions.
private static string GetAllProcessNames_wmic()

@kunalspathak kunalspathak merged commit c1fe87a into dotnet:main Feb 21, 2025
117 of 124 checks passed
@kunalspathak kunalspathak deleted the coretestlib branch February 21, 2025 06:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants