-
Notifications
You must be signed in to change notification settings - Fork 5k
Coretestlib: Add information of parent process id during test failure for Windows #112724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @hoyosjs |
azp run runtime-coreclr jitstress, runtime-coreclr jitstress2-jitstressregs |
/azp run runtime-coreclr jitstress, runtime-coreclr jitstress2-jitstressregs |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs:859
- The hardcoded wait time of 100 milliseconds might not be sufficient for the process to exit. Consider waiting for the process to exit without a timeout or handling the case where the process takes longer to complete.
process.WaitForExit(100);
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs:843
- [nitpick] The method name 'GetAllProcessNames_wmic' should use PascalCase for the acronym, like 'GetAllProcessNamesWmic', to be consistent with C# naming conventions.
private static string GetAllProcessNames_wmic()
Over past week, we have seen multiple hangs in windows/arm64 configuration, that doesn't repro locally. We want to understand why the dump of the hung process is not getting created. The parent process tries to iterate over the child processes but doesn't find the desired
corerun
child process and hence no dump is created. To make sure that the logic around that is correct, this PR adds logging of parent process id as well to make sure our dump collection logic gets triggered at right place.Reference: