[release/9.0] [browser][http] mute JS exceptions about network errors + HEAD verb #113261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: campersau <[email protected]>
…ver/Handlers/EchoHandler.cs Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: campersau <[email protected]>
…ver/Handlers/EchoHandler.cs Co-authored-by: campersau <[email protected]>
Co-authored-by: campersau <[email protected]>
github-actions
bot
requested review from
lewing,
pavelsavara,
lambdageek and
steveisok
as code owners
ghost
added
the
needs-area-label
pavelsavara
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/ncl |
|
cc @campersau |
lewing
approved these changes
Mar 7, 2025
This was referenced Mar 7, 2025
This was referenced Mar 7, 2025
|
@pavelsavara @lewing @steveisok Today is code complete for the April Release. If you want this fix included in this release, please get it approved by Tactics and merge it before 4pm PT. |
pavelsavara
added
Servicing-approved
|
/ba-g CI failures are unrelated |
|
is this still going out in the april release or now in may release? |
@radderz May, we didn't make it into the previous release train |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #113014 to release/9.0
/cc @pavelsavara
Customer Impact
In browser HTTP client we subscribe for rejected promises in order to suppress unhandled rejection of
AbortErrorwhen we issue the abort. The current handler also handles other network errors and aborts the whole program, which is not what it should do. Instead the network error should be propagated to managed HTTP client code.in Firefox when the verb is HEAD, the body is null. We should not fail because of that.
Passing
Responseas result ofhttp_wasm_fetchis creating JS memory leak by marshaling the object.Fixes #112172
Contributes to #111992
Regression
Testing
Automated tests.
Risk
Low
Both issues are only triggered when user enabled streaming responses. That's opt-in feature in Net9 and below.