Skip to content

[release/9.0-staging] [HttpStress] Fix Linux HttpStress build #113617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antonfirsov
Copy link
Member

Backport of #111664 to release/9.0-staging

Fixes #111660.

Customer Impact

N/A Test-only change

Regression

N/A Test-only change

Testing

This fixes the Linux build and restores HttpStress execution against release/9.0-staging.

Risk

None. Test-only change

@antonfirsov antonfirsov added this to the 9.0.x milestone Mar 17, 2025
@antonfirsov antonfirsov requested review from a team and Copilot March 17, 2025 16:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports changes to fix the Linux HttpStress build on release/9.0-staging, ensuring that tests run correctly. The key changes include:

  • Updating the docker-compose.yml file with a clarifying comment on the version attribute.
  • Changing the pipeline demand in http.yml to target Build.Ubuntu.2204.Amd64.Open.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml Added comment to address build issues on Ubuntu 2204
eng/pipelines/libraries/stress/http.yml Updated demand to reference the correct build image for Ubuntu 2204

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@antonfirsov
Copy link
Member Author

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov
Copy link
Member Author

Test-only change -> Tell mode.

@antonfirsov antonfirsov added the Servicing-approved Approved for servicing release label Mar 18, 2025
@antonfirsov antonfirsov merged commit 54ba56f into dotnet:release/9.0-staging Mar 18, 2025
89 of 91 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants