[release/9.0-staging] [debugger] Fix debugging a x86 app in mixed mode #114077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @tommcdon |
…mation to the context later.
github-actions
bot
force-pushed
the
backport/pr-114075-to-release/9.0-staging
branch
from
a11d532 to
a3133a0
Compare
|
Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date. |
jeffschwMSFT
approved these changes
Apr 11, 2025
jeffschwMSFT
added
the
Servicing-consider
tommcdon
approved these changes
Apr 11, 2025
|
Friendly reminder that code complete for the May release is next Monday April 14th. If you want this change included in that release, please take it to Tactics and merge the PR before EOD Monday. |
jeffschwMSFT
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114075 to release/9.0-staging
/cc @thaystg
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2428652
When a customer is trying to debug a x86 app from an AMD64, all the locals that are floating point are not displayed correctly and also the behavior of the program is wrong while debugging.
The runtime was getting the context from OS without asking for all the needed data, with that we are saving the wrong context, missing the float values, and restoring it also wrongly without this values, making the program work incorrectly and also the debugger couldn't show the correct values.
Regression
Testing
Manually tested.
Risk
Low risk, we are only getting the context with more fields for x86 machines.