Skip to content

[browser] Consider WasmSDK projects RID agnostic #114429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 9, 2025

Setting the property prevents project reference protocol from passing RID to referenced project build. It means that when server project is being built for more then one RID, referenced wasm project will be built just once.

Fixes dotnet/sdk-container-builds#625

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 9, 2025
@maraf maraf added this to the 10.0.0 milestone Apr 9, 2025
@maraf maraf self-assigned this Apr 9, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf marked this pull request as ready for review April 28, 2025 11:11
@Copilot Copilot AI review requested due to automatic review settings April 28, 2025 11:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.props: Language not supported

@lewing lewing requested a review from baronfel April 28, 2025 16:12
@baronfel
Copy link
Member

baronfel commented Apr 28, 2025

@maraf what's the easiest way for me to test this myself?

NVM I am silly - I can just set this property directly on a project that uses blazor wasm. I tested with the triggering project (SolisAgileManager) and it seems to work fantastically well.

Before
image

After
image

Only one instance of the actual publishing is getting called (because we're not clobbering input/output paths any longer)

@maraf maraf merged commit ac5ae4c into dotnet:main Apr 28, 2025
35 checks passed
@maraf maraf deleted the WasmSdkIsRidAgnostic branch April 28, 2025 18:29
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-RID publishing of an app that references a blazorwasm client app has exposes race conditions in client app build
3 participants