Sve2 AddHighNarrowing (Upper/Lower) #116848
Open
+374
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Jun 20, 2025
jacob-crawley
force-pushed
the
sve2-add-high
branch
from
f047986 to
32faa1e
Compare
jacob-crawley
force-pushed
the
sve2-add-high
branch
from
32faa1e to
9a5f186
Compare
| @@ -3564,7 +3564,6 @@ void emitter::emitInsSve_R_R_R(instruction ins, | |||
| case INS_sve_subhnt: | |||
| case INS_sve_rsubhnb: | |||
| case INS_sve_rsubhnt: | |||
| unreached(); // TODO-SVE: Not yet supported. | |||
There was a problem hiding this comment.
why is this removed? We added this because we couldn't verify the disasm and encoding. Please verify if this works by setting DOTNET_JitEmitUnitTestsSections=sve
| @@ -445,7 +443,7 @@ namespace JIT.HardwareIntrinsics.Arm | |||
| { | |||
| {RetBaseType}[] mask = new {RetBaseType}[RetElementCount]; | |||
| {Op1BaseType}[] left = new {Op1BaseType}[Op1ElementCount]; | |||
| {Op1BaseType}[] right = new {Op1BaseType}[Op1ElementCount]; | |||
| {Op2BaseType}[] right = new {Op2BaseType}[Op1ElementCount]; | |||
There was a problem hiding this comment.
Suggested change
| {Op2BaseType}[] right = new {Op2BaseType}[Op1ElementCount]; | |
| {Op2BaseType}[] right = new {Op2BaseType}[Op2ElementCount]; |
| @@ -195,11 +193,9 @@ namespace JIT.HardwareIntrinsics.Arm | |||
| Unsafe.CopyBlockUnaligned(ref Unsafe.As<{Op1VectorType}<{Op1BaseType}>, byte>(ref _fld1), ref Unsafe.As<{Op1BaseType}, byte>(ref _data1[0]), (uint)Unsafe.SizeOf<{Op1VectorType}<{Op1BaseType}>>()); | |||
| for (var i = 0; i < Op2ElementCount; i++) { _data2[i] = {NextValueOp2}; } | |||
| Unsafe.CopyBlockUnaligned(ref Unsafe.As<{Op2VectorType}<{Op2BaseType}>, byte>(ref _fld2), ref Unsafe.As<{Op2BaseType}, byte>(ref _data2[0]), (uint)Unsafe.SizeOf<{Op2VectorType}<{Op2BaseType}>>()); | |||
| for (var i = 0; i < RetElementCount; i++) { _maskData[i] = ({RetBaseType})_data1[i];} | |||
There was a problem hiding this comment.
why is this change? Since _trueFld and _falseFld are masks, they should be populated from _maskData. Also, _trueFld does not even have all true, so wondering why we decided to rename it?
kunalspathak
requested changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@a74nh @kunalspathak
Contributing towards #115479