Skip to content

Remove code coverage reporting from PRs #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

JoeRobich
Copy link
Member

No description provided.

@JoeRobich JoeRobich marked this pull request as ready for review April 19, 2021 23:38
@JoeRobich JoeRobich merged commit 5e19da1 into dotnet:master Apr 20, 2021
@andyleejordan
Copy link
Member

@JoeRobich May I ask what drove your reasons for removing Istanbul-based code coverage? I'm hopeful you found an alternative, as I've struggled to get it to instrument properly for my own Code extension (the PowerShell extension) when running on Azure DevOps CI. Was looking through the C# extension here for a working example.

@JoeRobich
Copy link
Member Author

I remember there being a lot of difficulties getting it to work as expected when moving from the vscode to the vscode-test package. The effort to get it working wasn't justified by the value we got from it.

@andyleejordan
Copy link
Member

Dang! It really seems to not work well in the case where there's a whole Node.JS app (Code) sitting between nyc and the actual tests. I might give up too 😢 Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants