Skip to content

Add 7.10 branches to conf.yaml #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2020
Merged

Add 7.10 branches to conf.yaml #1972

merged 3 commits into from
Oct 7, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 1, 2020 •
edited
Loading

This PR adds new 7.10 branches to the appropriate books.

NOTE: These build checks will fail until all the branches exist.

@lcawl lcawl added the release Apply to issues tracking docs for releases label Oct 1, 2020
@lcawl lcawl requested a review from jmikell821 October 1, 2020 20:40
gtback
gtback reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed we didn't add 7.10 to the Enterprise Search or some of the APM books. Was that intentional? Did you just add 7.10 whenever there was a 7.x?

conf.yaml Outdated
branches: [ master, 7.x, 7.9, 7.8 ]
live: [ master, 7.x, 7.9, 7.8 ]
branches: [ master, 7.x, 7.10, 7.9, 7.8 ]
live: [ master, 7.x, 7.10, 7.9, 7.8 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take 7.8 out of this list? Or can we change it to *stacklive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a question for @dedemorton. Can happen separately from this PR (before or after) as far as I'm concerned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcawl I think I did that before because I didn't have all the branches in the list. You should be able to use *stacklive now.

@lcawl
Copy link
Contributor Author

lcawl commented Oct 6, 2020 •
edited
Loading

Did you just add 7.10 whenever there was a 7.x?

Yup. I'll ping the writers for the books you mentioned, but I think we can follow up after this PR if necessary. If they don't have a 7.x there must not be links to those books from other books in the library.

@lcawl lcawl mentioned this pull request Oct 6, 2020
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Oct 7, 2020

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor Author

lcawl commented Oct 7, 2020

@elasticmachine run elasticsearch-ci/docs rebuild

@lcawl
Copy link
Contributor Author

lcawl commented Oct 7, 2020

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@lcawl
Copy link
Contributor Author

lcawl commented Oct 7, 2020

@elasticmachine run elasticsearch-ci/docs

@lcawl lcawl marked this pull request as ready for review October 7, 2020 18:38
@jmikell821 jmikell821 merged commit 16dccd5 into elastic:master Oct 7, 2020
@lcawl lcawl deleted the release-conf branch October 7, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback left review comments

@dedemorton dedemorton dedemorton left review comments

@jmikell821 jmikell821 jmikell821 approved these changes

Assignees
No one assigned
Labels
release Apply to issues tracking docs for releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @gtback @dedemorton @jmikell821