Skip to content

SQL fix params type #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

SQL fix params type #5046

merged 1 commit into from
Jul 31, 2025

Conversation

l-trotta
Copy link
Contributor

Originally reported in elastic/elasticsearch-java#721, params in SQL query request is an array of objects, not a map, as per the documentation and the server.

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit ccb9111 into main Jul 31, 2025
18 checks passed
@l-trotta l-trotta deleted the sql-params-fix branch July 31, 2025 09:48
github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-5046-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccb911165de728e8f329ef7734e33e7c20c72ed9
# Push it to GitHub
git push --set-upstream origin backport-5046-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-5046-to-8.17.

github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)
github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)
github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)
l-trotta added a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jul 31, 2025
(cherry picked from commit ccb9111)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants