Introduce a vectorized soarDistance function #129744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are computing soar distance in a two step process. First we compute the distance between the vector and the centroid using a vectorized function. Then we compute the residual using another vectorized function. Finally we compute the soar distance.
Looking at the distance and residual functions, they are actually executing very similar operations, therefore combining them in the same function should lead to a nice speed up. This commit replaces the method #soarResidual with a method call #soarDistance. Microbenchmarks shows a nice speed up in this operation:
Mac:
GCP: