Mute testSnapshotRestore in bcUpgradeTest #129767
Conversation
ldematte
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| @@ -15,4 +15,11 @@ tasks.register("bcUpgradeTest", StandaloneRestIntegTestTask) { | |||
| usesBwcDistribution(Version.fromString("0.0.0")) | |||
| systemProperty("tests.old_cluster_version", "0.0.0") | |||
| onlyIf("tests.bwc.main.version system property exists") { System.getProperty("tests.bwc.main.version") != null } | |||
| filter { | |||
| // Mute problematic tests | |||
| excludeTestsMatching("org.elasticsearch.upgrades.FullClusterRestartIT.testSnapshotRestore") | |||
There was a problem hiding this comment.
those class specific filters should be defined on the specific task not within the plugin in general IMO. That makes it easier to detect those filters for other engineers directly in the according build script without the need to dig into the plugin logic.
| @@ -15,4 +15,11 @@ tasks.register("bcUpgradeTest", StandaloneRestIntegTestTask) { | |||
| usesBwcDistribution(Version.fromString("0.0.0")) | |||
| systemProperty("tests.old_cluster_version", "0.0.0") | |||
| onlyIf("tests.bwc.main.version system property exists") { System.getProperty("tests.bwc.main.version") != null } | |||
| filter { | |||
| // Mute problematic tests | |||
There was a problem hiding this comment.
Can we add two words why those are problematic?
There was a problem hiding this comment.
The tests use string compare of version (from the cluster, saved in the snapshot) with tests.bwc.main.version , which is far from ideal.
But I've investigated this a bit more, and I think we can fix this another way. See #129769
(ignore the IndexVersion change, it's there to test the change is working and will be reverted).
Still, in any case, this test assertion is.. not ideal. I'll contact distributed and see if they can do better.
@breskeby wdyt? Better to go with #129769, or mute these tests?
There was a problem hiding this comment.
I'm fine with muting. but as said we should do it in the build script rather than here in the plugin
There was a problem hiding this comment.
Move filters to the specific projects; is that what you were thinking? (have I done it right?)
There was a problem hiding this comment.
yes thats what i meant :). Thank you.
💚 Backport successful
|
No description provided.