PR 1063 review #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alphabetical order Remove useless .node entry and build.series Signed-off-by: Frederic Pillon <[email protected]>
Remove useless comments Fix typo Update formatting (space, indent,...) Define Ax pins properly Remove HSE_BYPASS_NOT_USED as it will not be used. Signed-off-by: Frederic Pillon <[email protected]>
Comment PC_9 for I2C3 SDA as no I2C3 SCL pin available. Comment PG_9 for USART6 RX as no USART6 TX available. Comment several SPI pins as not all 3 required ones was available (MISO/MOSI/SCLK). So only SPI1 is available. Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stephenhensley
Here my review of your PR 1063
I've made some fix and clean up. See my commit message for more details.
I didn't check deeply the clock config, I assume you know what you want 😉 as you set it to 400MHz and not to 480 MHz and you test the Daisy board with it.
BR